On Wed, Aug 30, 2017 at 03:21:07PM +0300, Dan Carpenter wrote:
> The value of "size" comes from the user. When we add "start + size"
> it could lead to an integer overflow bug.
>
> It means we vmalloc() a lot more memory than we had intended. I believe
> that on 64 bit systems vmalloc() can succeed even if we ask it to
> allocate huge 4GB buffers. So we would get memory corruption and likely
> a crash when we call ha->isp_ops->write_optrom() and ->read_optrom().
>
> Only root can trigger this bug.
>
> Fixes: b7cc176c9eb3 ("[SCSI] qla2xxx: Allow region-based flash-part
> accesses.")
> Reported-by: shqking <[email protected]>
> Signed-off-by: Dan Carpenter <[email protected]>
Cc: stable <[email protected]>
perhaps?
thanks,
greg k-h
