On Fri, Sep 15, 2017 at 05:57:31PM +0000, Bart Van Assche wrote: > On Sat, 2017-09-16 at 00:44 +0800, Ming Lei wrote: > > If .queue_rq() returns BLK_STS_RESOURCE, blk-mq will rerun > > the queue in the three situations: > > > > 1) if BLK_MQ_S_SCHED_RESTART is set > > - queue is rerun after one rq is completed, see blk_mq_sched_restart() > > which is run from blk_mq_free_request() > > > > 2) BLK_MQ_S_TAG_WAITING is set > > - queue is rerun after one tag is freed > > > > 3) otherwise > > - queue is run immediately in blk_mq_dispatch_rq_list() > > > > So calling blk_mq_delay_run_hw_queue() inside .queue_rq() doesn't make > > sense because no matter it is called or not, the queue still will be > > rerun soon in above three situations, and the busy req can be dispatched > > again. > > NAK > > Block drivers call blk_mq_delay_run_hw_queue() if it is known that the queue > has to be rerun later even if no request has completed before the delay has > expired. This patch breaks at least the SCSI core and the dm-mpath drivers.
"if no request has completed before the delay has expired" can't be a reason to rerun the queue, because the queue can still be busy. The only reason is that there isn't any requests in-flight and queue is still busy, but I'd rather understand what the exact situation is, instead of using this kind of workaround. If no such situation, we should remove that. For SCSI, it might be reasonable to run the hw queue after a random time when atomic_read(&sdev->device_busy) is zero, that means the queue may be busy even when there isn't any requests in-flight in this queue. Could you or someone share what the case is? Then we can avoid to use this workaround. For dm-mpath, it might be related with path, but I have to say it is still a workaround. I suggest to understand the root cause, instead of keeping this ugly random delay because run hw queue after 100ms may be useless in 99.99% times. -- Ming
