Hi, Christoph, Can I put the declaration in asm/dma-coherence.h?
And, last time you said it is OK to pass a NULL to dma_get_cache_alignment() and cc all driver maintainers. I have do so. Huacai ------------------ Original ------------------ From: "Christoph Hellwig"<[email protected]>; Date: Mon, Sep 25, 2017 08:51 PM To: "Huacai Chen"<[email protected]>; Cc: "Christoph Hellwig"<[email protected]>; "Marek Szyprowski"<[email protected]>; "Robin Murphy"<[email protected]>; "Andrew Morton"<[email protected]>; "Fuxin Zhang"<[email protected]>; "linux-kernel"<[email protected]>; "Ralf Baechle"<[email protected]>; "James Hogan"<[email protected]>; "linux-mips"<[email protected]>; "James E . J . Bottomley"<[email protected]>; "Martin K . Petersen"<[email protected]>; "linux-scsi"<[email protected]>; "Roland Dreier"<[email protected]>; "Pawel Osciak"<[email protected]>; "Kyungmin Park"<[email protected]>; "Michael Chan"<[email protected]>; "Benjamin Herrenschmidt"<[email protected]>; "Ivan Mikhaylov"<[email protected]>; "Tariq Toukan"<[email protected]>; "Andy Gross"<[email protected]>; "Mark A . Greer"<[email protected]>; "Robert Baldyga"<[email protected]>; "stable"<[email protected]>; Subject: Re: [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment() > index aba7138..e2c5d9e 100644 > --- a/arch/mips/include/asm/dma-mapping.h > +++ b/arch/mips/include/asm/dma-mapping.h > @@ -39,4 +39,6 @@ static inline void arch_setup_dma_ops(struct device *dev, > u64 dma_base, > #endif > } > > +int mips_get_cache_alignment(struct device *dev); All the other mips generic dma helpers are prefixed mips_dma_* so it might make sense to follow that. Also please don't add arch-local helpers to asm/dma-mapping.h - this is a header used by linux/dma-mapping.h and should not contain implementation details if avoidable. > + dma_get_cache_alignment(NULL)) / > mdev->limits.mtt_seg_size; As said before - please don't pass NULL to this function but the proper device, which would be &mdev->pdev->dev in this case for example.
