Hi Bart, On Nov 28, 2017, at 2:27 PM, Bart Van Assche <[email protected]> wrote: > > On Tue, 2017-11-28 at 22:22 +0000, Madhani, Himanshu wrote: >> This was reported by customer so i am not very confident they would have >> CONFIG_PROVE_LOCKING enabled in >> their setup. I’ll enable this on our setup and we can try to reproduce this >> issue. >> >> Let me know if you want me to drop this patch until we get more details. > > Hello Himanshu, > > What I think is that at least an explanation should be provided about why it > is safe to leave out the spin_lock() and spin_unlock() calls. What does the > hardware lock protect and why is it safe to leave it out from > qla2x00_els_dcmd_iocb_timeout()? >
Okay will update patch with the description and submit v2 of this patch. > Thanks, > > Bart. Thanks, - Himanshu
