From: Quinn Tran <quinn.t...@cavium.com>

clear loop id after delete to prevent session invalidation
of stale session.

Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery")
Cc: <sta...@vger.kernel.org> # 4.10+
Signed-off-by: Quinn Tran <quinn.t...@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com>
---
 drivers/scsi/qla2xxx/qla_target.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_target.c 
b/drivers/scsi/qla2xxx/qla_target.c
index 1c219998ab60..0c0453f2ca9e 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -986,7 +986,7 @@ static void qlt_free_session_done(struct work_struct *work)
                        sess->send_els_logo = 0;
                }
 
-               if (sess->logout_on_delete) {
+               if (sess->logout_on_delete && sess->loop_id != FC_NO_LOOP_ID) {
                        int rc;
 
                        rc = qla2x00_post_async_logout_work(vha, sess, NULL);
@@ -1045,8 +1045,7 @@ static void qlt_free_session_done(struct work_struct 
*work)
                sess->login_succ = 0;
        }
 
-       if (sess->chip_reset != ha->base_qpair->chip_reset)
-               qla2x00_clear_loop_id(sess);
+       qla2x00_clear_loop_id(sess);
 
        if (sess->conflict) {
                sess->conflict->login_pause = 0;
@@ -4600,9 +4599,9 @@ qlt_find_sess_invalidate_other(scsi_qla_host_t *vha, 
uint64_t wwn,
                                    "Invalidating sess %p loop_id %d wwn 
%llx.\n",
                                    other_sess, other_sess->loop_id, other_wwn);
 
-
                                other_sess->keep_nport_handle = 1;
-                               *conflict_sess = other_sess;
+                               if (other_sess->disc_state != DSC_DELETED)
+                                       *conflict_sess = other_sess;
                                qlt_schedule_sess_for_deletion(other_sess,
                                    true);
                        }
-- 
2.12.0

Reply via email to