On Wed, 2017-12-06 at 21:03 -0500, Martin K. Petersen wrote: > > These three patches is what I came up with after having reviewed > > recent changes in the code for handling blacklist flags > > handling. Please consider these patches for kernel v4.16. > > I applied 1 and 3 to 4.16/scsi-queue. I am still not a fan of forcing > u32. That's a recipe for disaster when we add the next flag.
Hello Martin, Are you perhaps referring to the five __force casts? If so, do you have a suggestion for avoiding that sparse reports false positive warnings on the conversions between int and blist_flags_t? The only approach I can think of to reduce the number of __force casts is to embed these __force casts into two helper functions - one for the conversion from int to blist_flags_t and one for the conversion the other way around. Thanks, Bart.
