> -----Original Message-----
> From: Bart Van Assche [mailto:bart.vanass...@wdc.com]
> Sent: Thursday, December 21, 2017 10:41 AM
> To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta
> <raghavaaditya.renuku...@microsemi.com>; linux-scsi@vger.kernel.org;
> martin.peter...@oracle.com
> Cc: dl-esc-Aacraid Linux Driver <aacr...@microsemi.com>;
> gpicc...@linux.vnet.ibm.com; Tom White <tom.wh...@microsemi.com>;
> Scott Benesh <scott.ben...@microsemi.com>
> Subject: Re: [PATCH 15/29] scsi: aacraid: Create helper functions to get lun
> info
> 
> EXTERNAL EMAIL
> 
> 
> On Thu, 2017-12-21 at 09:34 -0800, Raghava Aditya Renukunta wrote:
> > +     return ((phys_luns->list_length[0]<<24) +
> > +                     (phys_luns->list_length[1]<<16) +
> > +                     (phys_luns->list_length[2]<<8) +
> > +                     (phys_luns->list_length[3])) / 24;
> 
> Please use get_unaligned_be32() instead of open-coding it.

Yes Will do Bart.
Thank you
Raghava Aditya
 

> Thanks,
> 
> Bart.

Reply via email to