Re: [PATCH v4 02/10] ufs: sysfs: device descriptor

[Greg KH]

On Thu, Feb 01, 2018 at 06:15:38PM +0200, Stanislav Nijnikov wrote:
> +#define UFS_DESC_PARAM(_name, _puname, _duname, _size)                       
>  \
> +static ssize_t _name##_show(struct device *dev,                              
>  \
> +     struct device_attribute *attr, char *buf)                             \
> +{                                                                            
>  \
> +     struct ufs_hba *hba = dev_get_drvdata(dev);                           \
> +     return ufs_sysfs_read_desc_param(hba, QUERY_DESC_IDN_##_duname,       \
> +             0, _duname##_DESC_PARAM##_puname,                             \
> +             buf, UFS_PARAM_##_size##_SIZE);                               \
> +}                                                                            
>  \
> +static DEVICE_ATTR_RO(_name)

Nit, use tabs in your lines here to line up the trailing \

Same for other places in this patch series.

thanks,

greg k-h