Hi Arnaldo, I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6 next-20180322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arnaldo-Carvalho-de-Melo/target-Use-WARNON_NON_RT-irqs_disabled/20180322-174549 config: i386-randconfig-s1-03221113 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/target/target_core_transport.c: In function '__transport_check_aborted_status': >> drivers/target/target_core_transport.c:3207:2: error: implicit declaration >> of function 'WARN_ON_ONCE_NONRT' [-Werror=implicit-function-declaration] WARN_ON_ONCE_NONRT(!irqs_disabled()); ^~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/WARN_ON_ONCE_NONRT +3207 drivers/target/target_core_transport.c 3199 3200 static int __transport_check_aborted_status(struct se_cmd *cmd, int send_status) 3201 __releases(&cmd->t_state_lock) 3202 __acquires(&cmd->t_state_lock) 3203 { 3204 int ret; 3205 3206 assert_spin_locked(&cmd->t_state_lock); > 3207 WARN_ON_ONCE_NONRT(!irqs_disabled()); 3208 3209 if (!(cmd->transport_state & CMD_T_ABORTED)) 3210 return 0; 3211 /* 3212 * If cmd has been aborted but either no status is to be sent or it has 3213 * already been sent, just return 3214 */ 3215 if (!send_status || !(cmd->se_cmd_flags & SCF_SEND_DELAYED_TAS)) { 3216 if (send_status) 3217 cmd->se_cmd_flags |= SCF_SEND_DELAYED_TAS; 3218 return 1; 3219 } 3220 3221 pr_debug("Sending delayed SAM_STAT_TASK_ABORTED status for CDB:" 3222 " 0x%02x ITT: 0x%08llx\n", cmd->t_task_cdb[0], cmd->tag); 3223 3224 cmd->se_cmd_flags &= ~SCF_SEND_DELAYED_TAS; 3225 cmd->scsi_status = SAM_STAT_TASK_ABORTED; 3226 trace_target_cmd_complete(cmd); 3227 3228 spin_unlock_irq(&cmd->t_state_lock); 3229 ret = cmd->se_tfo->queue_status(cmd); 3230 if (ret) 3231 transport_handle_queue_full(cmd, cmd->se_dev, ret, false); 3232 spin_lock_irq(&cmd->t_state_lock); 3233 3234 return 1; 3235 } 3236 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
