Hi Lee,

I love your patch! Yet something to improve:

[auto build test ERROR on target/for-next]
[also build test ERROR on v4.16 next-20180406]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Lee-Duncan/target-prefer-dbroot-of-etc-target-over-var-target/20180406-234105
base:   https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git 
for-next
config: i386-randconfig-a0-201813 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/target/target_core_configfs.c: In function 'target_init_dbroot':
>> drivers/target/target_core_configfs.c:3222:39: error: 'DB_ROOT_PREFERRED' 
>> undeclared (first use in this function)
     snprintf(db_root_stage, DB_ROOT_LEN, DB_ROOT_PREFERRED);
                                          ^
   drivers/target/target_core_configfs.c:3222:39: note: each undeclared 
identifier is reported only once for each function it appears in

vim +/DB_ROOT_PREFERRED +3222 drivers/target/target_core_configfs.c

  3217  
  3218  static void target_init_dbroot(void)
  3219  {
  3220          struct file *fp;
  3221  
> 3222          snprintf(db_root_stage, DB_ROOT_LEN, DB_ROOT_PREFERRED);
  3223          fp = filp_open(db_root_stage, O_RDONLY, 0);
  3224          if (IS_ERR(fp)) {
  3225                  pr_err("db_root: cannot open: %s\n", db_root_stage);
  3226                  return;
  3227          }
  3228          if (!S_ISDIR(file_inode(fp)->i_mode)) {
  3229                  filp_close(fp, NULL);
  3230                  pr_err("db_root: not a valid directory: %s\n", 
db_root_stage);
  3231                  return;
  3232          }
  3233          filp_close(fp, NULL);
  3234  
  3235          strncpy(db_root, db_root_stage, DB_ROOT_LEN);
  3236          pr_debug("Target_Core_ConfigFS: db_root set to %s\n", db_root);
  3237  }
  3238  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to