in the meantime, I've disabled WRITE SAME for  mptsas:

diff -Naur linux-4.14/drivers/message/fusion/mptsas.c 
linux-4.14-mptsas-disable-write-same/drivers/message/fusion/mptsas.c
--- linux-4.14/drivers/message/fusion/mptsas.c        2017-11-12 
19:46:13.000000000 +0100
+++ linux-4.14-mptsas-disable-write-same/drivers/message/fusion/mptsas.c        
    2018-04-12 09:17:32.625670996 +0200
@@ -1995,6 +1995,7 @@
   .cmd_per_lun                 = 7,
   .use_clustering                      = ENABLE_CLUSTERING,
   .shost_attrs                                 = mptscsih_host_attrs,
+  .no_write_same                                       = 1,
 };

errors are gone... this is kinda of hammer solution, as I suppose it'll
be better to blacklist only particular models, right? if so, I'd try to
create more  complex patch..

but I guess I should be safe for now..

BR

nik

On Thu, Apr 12, 2018 at 08:50:23AM +0200, Nikola Ciprich wrote:
> hmm, further checking 4.4.52, it was not really OK too:
> 
> [ 1895.084325] blk_update_request: I/O error, dev sda, sector 239461608
> [ 1895.101099] sd 4:1:1:0: [sda] tag#1 FAILED Result: hostbyte=DID_OK 
> driverbyte=DRIVER_SENSE
> [ 1895.101101] sd 4:1:1:0: [sda] tag#1 Sense Key : Illegal Request [current] 
> [ 1895.101103] sd 4:1:1:0: [sda] tag#1 Add. Sense: No additional sense 
> information
> [ 1895.101105] sd 4:1:1:0: [sda] tag#1 CDB: Write Same(10) 41 00 0e 45 e5 08 
> 00 00 10 00
> [ 1895.101106] blk_update_request: I/O error, dev sda, sector 239461640
> 
> so 4.14.x "only" brings delayed allocation errors.
> 
> but I repeat, drives are 100% OK, so it must be either HW or driver problem.
> 
> now looking more at the errors, I guess it's "only" problem with WRITE SAME 
> command?
> 
> should it be blacklisted for those adapters?
> 
> 
> 
> On Thu, Apr 12, 2018 at 08:13:47AM +0200, Nikola Ciprich wrote:
> > Hi,
> > 
> > after switch from 4.4 to 4.14 we're getting reports of delayed allocation
> > failures on ext4 filesystems. Since we're getting it on many machines, 
> > including
> > brand new or with new harddrives replaced, I don't think it's disk issue.
> > 
> > here's example of the warning:
> > 
> > [52455.961319] sd 4:1:4:0: [sda] tag#11 FAILED Result: hostbyte=DID_OK 
> > driverbyte=DRIVER_SENSE
> > [52455.961322] sd 4:1:4:0: [sda] tag#11 Sense Key : Illegal Request 
> > [current] 
> > [52455.961324] sd 4:1:4:0: [sda] tag#11 Add. Sense: No additional sense 
> > information
> > [52455.961327] sd 4:1:4:0: [sda] tag#11 CDB: Write Same(10) 41 00 01 1c 3b 
> > 28 00 00 08 00
> > [52455.961329] print_req_error: I/O error, dev sda, sector 18627368
> > [52455.961339] EXT4-fs (dm-3): Delayed block allocation failed for inode 
> > 393338 at logical offset 1125 with max blocks 1 with error 5
> > [52455.961342] EXT4-fs (dm-3): This should not happen!! Data will be lost
> > 
> > checking filesystem does not show any problem, but this does not make me 
> > any calmer..
> > 
> > any idea on what might cause this?
> > 
> > this particular machine is IBM System x3200 M2, with
> > LSI Logic / Symbios Logic SAS1064ET PCI-Express Fusion-MPT SAS (rev 02)
> > 
> > OS is centos 7, kernel 4.14.16
> > 
> > If I could provide any further info, please let me know..
> > 
> > BR
> > 
> > nik
> > 
> > -- 
> > -------------------------------------
> > Ing. Nikola CIPRICH
> > LinuxBox.cz, s.r.o.
> > 28.rijna 168, 709 00 Ostrava
> > 
> > tel.:   +420 591 166 214
> > fax:    +420 596 621 273
> > mobil:  +420 777 093 799
> > www.linuxbox.cz
> > 
> > mobil servis: +420 737 238 656
> > email servis: ser...@linuxbox.cz
> > -------------------------------------
> > 
> 
> -- 
> -------------------------------------
> Ing. Nikola CIPRICH
> LinuxBox.cz, s.r.o.
> 28.rijna 168, 709 00 Ostrava
> 
> tel.:   +420 591 166 214
> fax:    +420 596 621 273
> mobil:  +420 777 093 799
> www.linuxbox.cz
> 
> mobil servis: +420 737 238 656
> email servis: ser...@linuxbox.cz
> -------------------------------------
> 

-- 
-------------------------------------
Ing. Nikola CIPRICH
LinuxBox.cz, s.r.o.
28.rijna 168, 709 00 Ostrava

tel.:   +420 591 166 214
fax:    +420 596 621 273
mobil:  +420 777 093 799
www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: ser...@linuxbox.cz
-------------------------------------

Reply via email to