On 5/22/18 12:59 PM, Kees Cook wrote: > On Tue, May 22, 2018 at 11:50 AM, Martin K. Petersen > <martin.peter...@oracle.com> wrote: >> >> Christoph, >> >>> On Tue, May 22, 2018 at 11:15:09AM -0700, Kees Cook wrote: >>>> Both SCSI and ATAPI share the sense header. In preparation for using the >>>> struct scsi_sense_hdr more widely, move this into a separate header and >>>> move the helper function to scsi_ioctl.c which is linked with CONFIG_IDE >>>> by way of CONFIG_BLK_SCSI_REQUEST. >>> >>> Please keep the code where it is and just depend on SCSI on the legacy >>> ide driver. No need to do gymnastics just for a legacy case. >> >> Yup, I agree. > > Oh, er, this was mainly done at Jens's request. Jens, can you advise?
I think Martin and Christoph are objecting to moving the code to block/scsi_ioctl.h. I don't care too much about where the code is, but think it would be nice to have the definitions in a separate header. But if they prefer just pulling in all of SCSI for it, well then I guess it's pointless to move the header bits. Seems very heavy handed to me, though. -- Jens Axboe
