Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

[Sebastian Andrzej Siewior]

On 2018-05-24 10:58:44 [+0800], Jason Yan wrote:
> I think it's fine to delete this irq save code. As for the "TODO"
> comment, I think we can add:
> 
> BUG_ON(!irqs_disabled());
> 
> or
> 
> WARN_ON_ONCE(!irqs_disabled());

no, please don't do this. Please add instead
        lockdep_assert_held()

on the lock in question and let lockdep to its work. Lockdep has way
better coverage than your irqs_disabled() check which also breaks RT.

> and then delete the "TODO" comment.

Sebastian