Hi Sayali, I have several notes about the patches: 1. New descriptors structures are redefinition of the descriptors info (see definitions of device_desc_param, unit_desc_param, etc in drivers/scsi/ufs/ufs.h) 2. You didn't took into consideration the recently added UFS sysfs infostructure. 3. The idea of passing the binary buffer as a string is a bit flawed and the parser doesn't provide any protection against bad data (e.g just send the string "100").
Regards Stanislav > -----Original Message----- > From: [email protected] <[email protected]> On > Behalf Of Sayali Lokhande > Sent: Tuesday, May 22, 2018 7:22 AM > To: [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected] > Cc: [email protected]; Sayali Lokhande <[email protected]> > Subject: [PATCH RFC 0/3] Add ufs provisioning support in driver > > This change adds a new API ufshcd_do_config_device() to > write configuration descriptor with the provisioning data. > Sysfs support is added in driver to trigger ufs provisioning at > runtime. Provisioning data is parsed from vendor specific provisioning > file. This parsed data is passed as a buffer via sysfs to provision > ufs device. > > Sayali Lokhande (2): > scsi: ufs: Add ufs provisioning support > scsi: ufs: Add sysfs support for ufs provision > > Subhash Jadavani (1): > scsi: ufs: set the device reference clock setting > > .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 8 + > drivers/scsi/ufs/ufs.h | 39 +++ > drivers/scsi/ufs/ufshcd-pltfrm.c | 20 ++ > drivers/scsi/ufs/ufshcd.c | 383 > +++++++++++++++++++++ > drivers/scsi/ufs/ufshcd.h | 9 + > 5 files changed, 459 insertions(+) > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project
