Ok thanks. Will test and those as the first 2 patches in the series. Thanks a lot, Avri
> -----Original Message----- > From: Christoph Hellwig <h...@lst.de> > Sent: Wednesday, September 05, 2018 8:15 PM > To: Avri Altman <avri.alt...@wdc.com> > Cc: Christoph Hellwig <h...@lst.de>; Johannes Thumshirn > <jthumsh...@suse.de>; Hannes Reinecke <h...@suse.com>; Bart Van Assche > <bart.vanass...@wdc.com>; James E.J. Bottomley > <j...@linux.vnet.ibm.com>; Martin K. Petersen > <martin.peter...@oracle.com>; linux-scsi@vger.kernel.org; Stanislav Nijnikov > <stanislav.nijni...@wdc.com>; Avi Shchislowski > <avi.shchislow...@wdc.com>; Alex Lemberg <alex.lemb...@wdc.com>; > Subhash Jadavani <subha...@codeaurora.org>; Vinayak Holikatti > <vinayak.holika...@wdc.com> > Subject: Re: [PATCH v3 3/7] scsi: ufs: Add fill task management request > > On Wed, Sep 05, 2018 at 07:08:50PM +0200, Christoph Hellwig wrote: > > On Wed, Sep 05, 2018 at 03:53:41PM +0000, Avri Altman wrote: > > > But on the other hand, task management request and response UPIUs > > > are honorable members of the ufs spec (JEDEC 220C paragraphs 10.7.6 & > 10.7.7). > > > and indeed they lives in ufs.h, where they should. > > > > There is no other use anywhere. Remember that there is no need to > > have C data structure match what is in the spec, in fact doing so > > often leads to worse code, which is why we often avoid it. > > > > I'll send out a little series (untested) to show how I'd like to see > > this task menagement code look like. > > Ok, the wifi at the meeting I'm at right now doesn't allow sending > mail, so here are the patches as an attachment.
