Hi Bart, > On Sep 15, 2018, at 9:50 PM, Bart Van Assche <[email protected]> wrote: > > External Email > > On 09/14/18 14:28, Himanshu Madhani wrote: >> diff --git a/drivers/scsi/qla2xxx/qla_nvmet.c >> b/drivers/scsi/qla2xxx/qla_nvmet.c >> new file mode 100644 >> [ ... ] >> +#if IS_ENABLED(CONFIG_NVME_TARGET_FC) >> [ ... ] >> +#endif > > This style of using #if / #endif is not acceptable. Instead, > drivers/scsi/qla2xxx/Makefile should be modified such that qla_nvmet.c > is only built if CONFIG_NVME_TARGET_FC has been set. > > Bart. >
Thanks for the input. We’ll make changes and resubmit. Thanks, - Himanshu
