> >
> > diff --git a/include/uapi/scsi/scsi_bsg_ufs.h
> > b/include/uapi/scsi/scsi_bsg_ufs.h
> > new file mode 100644
> > index 0000000..4108ce3
> > --- /dev/null
> > +++ b/include/uapi/scsi/scsi_bsg_ufs.h
> > @@ -0,0 +1,74 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * TBD - UFS Transport SGIO v4 BSG Message Support
>
> What does the TBD stand for here? I'd just remove it.
Done.
>
> > +struct utp_upiu_query {
> > + u8 opcode;
> > + u8 idn;
> > + u8 index;
> > + u8 selector;
>
> Please use __u8 instead of u8 for uapi headers.
Done.
>
> With those tweaks it looks fine to me:
>
> Reviewed-by: Christoph Hellwig <[email protected]>
