Ewan,

>> +    if (!elsiocb->context1)
>> +            goto dropit;
>> +
>>      if ((cmd & ELS_CMD_MASK) == ELS_CMD_RSCN) {
>>              cmd &= ELS_CMD_MASK;
>>      }
>
> Well, that's fine.  But if lpfc_nlp_get() can return NULL, because the
> ndlp structure could be going away, perhaps we should be looking more
> closely at the code in lpfc_nlp_get() that uses the structure a bunch of
> times, including dereferencing ndlp->phba and taking the phba->nlp_lock
> before taking a kref on it?  (As well as the debugging log calls...)

Hannes? James?

-- 
Martin K. Petersen      Oracle Linux Engineering

Reply via email to