Hi linux-scsi-owner, Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on v4.19 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/linux-scsi-owner-vger-kernel-org/sg-types-and-naming-cleanup/20181026-220008 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: i386-randconfig-x014-201842 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): In file included from include/linux/kernel.h:14:0, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/scsi/sg.c:22: drivers/scsi/sg.c: In function 'init_sg': >> drivers/scsi/sg.c:2277:3: error: 'sg_version_date' undeclared (first use in >> this function); did you mean 'sg_version_num'? sg_version_date); ^ include/linux/printk.h:315:34: note: in definition of macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ drivers/scsi/sg.c:2277:3: note: each undeclared identifier is reported only once for each function it appears in sg_version_date); ^ include/linux/printk.h:315:34: note: in definition of macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~ drivers/scsi/sg.c: At top level: drivers/scsi/sg.c:246:20: warning: 'sg_rq_state_str' used but never defined static const char *sg_rq_state_str(enum sg_rq_state rq_state, bool long_str); ^~~~~~~~~~~~~~~ vim +2277 drivers/scsi/sg.c 2256 2257 static int __init 2258 init_sg(void) 2259 { 2260 int rc; 2261 2262 if (scatter_elem_sz < PAGE_SIZE) { 2263 scatter_elem_sz = PAGE_SIZE; 2264 scatter_elem_sz_prev = scatter_elem_sz; 2265 } 2266 if (def_reserved_size >= 0) 2267 sg_big_buff = def_reserved_size; 2268 else 2269 def_reserved_size = sg_big_buff; 2270 2271 rc = register_chrdev_region(MKDEV(SCSI_GENERIC_MAJOR, 0), 2272 SG_MAX_DEVS, "sg"); 2273 if (rc) 2274 return rc; 2275 pr_info("Registered %s[char major=0x%x], version: %s, date: %s\n", 2276 "sg device ", SCSI_GENERIC_MAJOR, SG_VERSION_STR, > 2277 sg_version_date); 2278 sg_sysfs_class = class_create(THIS_MODULE, "scsi_generic"); 2279 if ( IS_ERR(sg_sysfs_class) ) { 2280 rc = PTR_ERR(sg_sysfs_class); 2281 goto err_out; 2282 } 2283 sg_sysfs_valid = 1; 2284 rc = scsi_register_interface(&sg_interface); 2285 if (0 == rc) { 2286 #ifdef CONFIG_SCSI_PROC_FS 2287 sg_proc_init(); 2288 #endif /* CONFIG_SCSI_PROC_FS */ 2289 return 0; 2290 } 2291 class_destroy(sg_sysfs_class); 2292 err_out: 2293 unregister_chrdev_region(MKDEV(SCSI_GENERIC_MAJOR, 0), SG_MAX_DEVS); 2294 return rc; 2295 } 2296 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
