Hi Mike
On Tue, 30 Oct 2018 10:54:07 -0500, Mike Christie wrote:
> >> This patchset removes a couple of unused error stat counters and a
> >> redundant cumulative counter.
> >> I've tagged this patchset RFC, as it may be considered a kernel<->user
> >> (configfs) API change.
> >
> > Ping, any thoughts on this patchset?
> >
>
> I think these stats were supposed to match the iSCSI MIB definitions. It
> was not clear why we didn't just fix them so they report the correct values?
I finally got a chance to look through rfc#4544. It does indeed look
like these counters correspond to:
IscsiInstanceSsnErrorStatsEntry ::= SEQUENCE {
iscsiInstSsnDigestErrors Counter32,
iscsiInstSsnCxnTimeoutErrors Counter32,
iscsiInstSsnFormatErrors Counter32
}
There doesn't appear to be anything stopping us from plumbing them into
the corresponding error paths, so I'll withdraw this patchset.
Cheers, David
