On 10/3/18 5:44 PM, [email protected] wrote: > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > > *From:*Gustavo A. R. Silva <[email protected]> > *Sent:* Wednesday, October 3, 2018 9:55 AM > *To:* Don Brace; James E.J. Bottomley; Martin K. Petersen; Adaptec OEM Raid > Solutions; Willem Riede; Kai Mäkisara > *Cc:* [email protected]; [email protected]; > [email protected]; [email protected]; Gustavo A. R. > Silva > *Subject:* [PATCH] scsi: mark expected switch fall-throughs > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <[email protected]> > --- > drivers/scsi/hpsa.c | 5 +++++ > drivers/scsi/ips.c | 1 + > drivers/scsi/osst.c | 6 ++++++ > drivers/scsi/ppa.c | 1 + > drivers/scsi/st.c | 4 ++++ > 5 files changed, 17 insertions(+) > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index f903983..fb6a356 100644 > --- a/drivers/scsi/hpsa.c > +++ b/drivers/scsi/hpsa.c > @@ -4662,6 +4662,7 @@ static int fixup_ioaccel_cdb(u8 *cdb, int *cdb_len) > case WRITE_6: > case WRITE_12: > is_write = 1; > + /* fall through */ > case READ_6: > case READ_12: > if (*cdb_len == 6) { > @@ -5092,6 +5093,7 @@ static int hpsa_scsi_ioaccel_raid_map(struct ctlr_info > *h, > switch (cmd->cmnd[0]) { > case WRITE_6: > is_write = 1; > + /* fall through */ > case READ_6: > first_block = (((cmd->cmnd[1] & 0x1F) << 16) | > (cmd->cmnd[2] << 8) | > @@ -5102,6 +5104,7 @@ static int hpsa_scsi_ioaccel_raid_map(struct ctlr_info > *h, > break; > case WRITE_10: > is_write = 1; > + /* fall through */ > case READ_10: > first_block = > (((u64) cmd->cmnd[2]) << 24) | > @@ -5114,6 +5117,7 @@ static int hpsa_scsi_ioaccel_raid_map(struct ctlr_info > *h, > break; > case WRITE_12: > is_write = 1; > + /* fall through */ > case READ_12: > first_block = > (((u64) cmd->cmnd[2]) << 24) | > @@ -5128,6 +5132,7 @@ static int hpsa_scsi_ioaccel_raid_map(struct ctlr_info > *h, > break; > case WRITE_16: > is_write = 1; > + /* fall through */ > case READ_16: > first_block = > (((u64) cmd->cmnd[2]) << 56) | > > > > Tested-by: Don Brace <[email protected]> > Acked-by: Don Brace <[email protected]> >
Thanks for this, but please don't remove the Coverity tags. -- Gustavo
