On 2018/10/11 23:42, Ewan D. Milne wrote: > So in v2 you moved the #ifdef CONFIG_BLK_DEV_ZONED > so that nr_zones is always present? It was previously > changed to keep the request_queue size smaller. > > Would make more sense to make the nr_zones sysfs > code here conditional on CONFIG_BLK_DEV_ZONED? >
Yes, I guess it would. #ifdef in c code is normally not welcome, so I was a little heavy handed with this v2 change to avoid adding any to blk-sysfs.c :) I will rework this and send a v3. Thanks for the review. -- Damien Le Moal Western Digital Research
