On Wed, Oct 17, 2018 at 02:49:50PM +0200, Johannes Thumshirn wrote:
> On 17/10/18 14:34, YueHaibing wrote:
> > - srb_tag = le32_to_cpu(scsiqp->srb_tag);
> > scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag);
>
> Shouldn't this be:
> scp = scsi_host_find_tag(boardp->shost,
> le32_to_cpu(scsiqp->srb_tag));
I don't think so. Look at how scsiqp->srb_tag is set:
adv_build_req(struct asc_board *boardp, struct scsi_cmnd *scp,
ADV_SCSI_REQ_Q **adv_scsiqpp)
{
+ u32 srb_tag = scp->request->tag;
...
+ scsiqp->srb_tag = srb_tag;
If we're not converting it to le32 on the way in, we probably don't want
to convert it back on the way out.
Please don't make me power up my PA-RISC machine with an Advansys card
in it, just to find out ...
