On Fri, Oct 26, 2018 at 11:01 AM Bart Van Assche <[email protected]> wrote: > > On Fri, 2018-10-26 at 10:54 -0700, Nick Desaulniers wrote: > > If creating one instance of this variable is a functional change, I > > can't help but suspect the original code was wrong. But maybe Bart, > > Boaz, or Christoph can clarify or have more thoughts on this? Looks > > like Boaz added this header in commit de258bf5e638 ("[SCSI] libosd: > > OSDv1 Headers"). > > Hi Nick and Nathan, > > Had you noticed the following e-mail from early October: > https://marc.info/?l=linux-kernel&m=153849955503249?
>From this subthread with Linus, removal of the exofs fs and scsi osd code would be a user visible change and is not an option. See: https://lkml.org/lkml/2018/10/27/3 https://lkml.org/lkml/2018/10/27/44 So we should pursue this much smaller fixup. Boaz, can you clarify https://lkml.org/lkml/2018/10/26/682 specifically: > If creating one instance of this variable is a functional change, I > can't help but suspect the original code was wrong. But maybe Bart, > Boaz, or Christoph can clarify or have more thoughts on this? Looks > like Boaz added this header in commit de258bf5e638 ("[SCSI] libosd: > OSDv1 Headers"). -- Thanks, ~Nick Desaulniers
