On Mon, 2018-10-29 at 10:37 -0600, Jens Axboe wrote:
> The mapping used to be dependent on just the CPU location, but
> now it's a tuple of { type, cpu} instead. This is a prep patch
> for allowing a single software queue to map to multiple hardware
> queues. No functional changes in this patch.

A nitpick: mathematicians usually use the { } notation for sets and () for
tuples. See also https://en.wikipedia.org/wiki/Tuple.

> +             /* wrap */
> +             BUG_ON(!hctx->nr_ctx);

Another nitpick: how about changing the "wrap" comment into "detect integer
overflow" or so to make the purpose of the BUG_ON() statement more clear?

Thanks,

Bart.

Reply via email to