On Mon, 2018-10-29 at 10:37 -0600, Jens Axboe wrote:
> struct blk_mq_tag_set {
> -     unsigned int            *mq_map;
> +     struct blk_mq_queue_map map[HCTX_MAX_TYPES];
>       const struct blk_mq_ops *ops;
>       unsigned int            nr_hw_queues;
>       unsigned int            queue_depth;    /* max hw supported */

How about documenting that nr_hw_queues is the number of hardware queues across
all hardware queue types instead of e.g. the number of hardware queues for a
single hardware queue type? This is something that only became clear to me after
having reviewed a later patch in this series. Anyway:

Reviewed-by: Bart Van Assche <[email protected]>

Reply via email to