[ Dropping large CC list ]

On 20/12/2018 15:43, Marc Gonzalez wrote:

> I think I've checked every low-level thingamajig:
> clocks, regulators, power domains, gdsc, voltage spec

I found something else, by comparing the writes to the PHY and HC,
downstream vs upstream:

ufs_qcom_link_startup_post_change() calls
ufs_qcom_phy_ctrl_rx_linecfg(phy, false);
on my 8098 board (downstream, but not upstream)

(Maybe this write is not required on sdm845...)

Will test next week. Crossing my fingers that I've found
the needle in the proverbial haystack :-)

The comment is very promising:

        /*
         * Some UFS devices send incorrect LineCfg data as part of power mode
         * change sequence which may cause host PHY to go into bad state.
         * Disabling Rx LineCfg of host PHY should help avoid this.
         */

https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/drivers/scsi/ufs/ufs-qcom.c?h=LE.UM.1.3.r3.25#n658

Regards.

Reply via email to