Hi Douglas, Thank you for the patch! Yet something to improve:
[auto build test ERROR on scsi/for-next] [also build test ERROR on v4.20 next-20181224] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Douglas-Gilbert/scsi-add-debugfs-directories/20190101-234113 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: i386-randconfig-s0-201900 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/scsi/scsi.o: In function `exit_scsi': >> drivers/scsi/scsi.c:856: undefined reference to `scsi_debugfs_root' drivers/scsi/scsi.o: In function `init_scsi': drivers/scsi/scsi.c:817: undefined reference to `scsi_debugfs_root' >> drivers/scsi/scsi.c:820: undefined reference to `scsi_debugfs_uld' drivers/scsi/scsi.c:823: undefined reference to `scsi_debugfs_root' >> drivers/scsi/scsi.c:823: undefined reference to `scsi_debugfs_lld' drivers/scsi/scsi.c:833: undefined reference to `scsi_debugfs_root' vim +856 drivers/scsi/scsi.c 790 791 static int __init init_scsi(void) 792 { 793 int error; 794 795 error = scsi_init_queue(); 796 if (error) 797 return error; 798 error = scsi_init_procfs(); 799 if (error) 800 goto cleanup_queue; 801 error = scsi_init_devinfo(); 802 if (error) 803 goto cleanup_procfs; 804 error = scsi_init_hosts(); 805 if (error) 806 goto cleanup_devlist; 807 error = scsi_init_sysctl(); 808 if (error) 809 goto cleanup_hosts; 810 error = scsi_sysfs_register(); 811 if (error) 812 goto cleanup_sysctl; 813 814 scsi_netlink_init(); 815 816 #ifdef CONFIG_DEBUG_FS 817 scsi_debugfs_root = debugfs_create_dir("scsi", NULL); 818 if (!scsi_debugfs_root) 819 goto cleanup_netlink; > 820 scsi_debugfs_uld = debugfs_create_dir("uld", scsi_debugfs_root); 821 if (!scsi_debugfs_uld) 822 goto cleanup_debugfs; > 823 scsi_debugfs_lld = debugfs_create_dir("lld", scsi_debugfs_root); 824 if (!scsi_debugfs_lld) 825 goto cleanup_debugfs; 826 #endif 827 828 printk(KERN_NOTICE "SCSI subsystem initialized\n"); 829 return 0; 830 831 #ifdef CONFIG_DEBUG_FS 832 cleanup_debugfs: 833 debugfs_remove_recursive(scsi_debugfs_root); 834 cleanup_netlink: 835 scsi_netlink_exit(); 836 #endif 837 cleanup_sysctl: 838 scsi_exit_sysctl(); 839 cleanup_hosts: 840 scsi_exit_hosts(); 841 cleanup_devlist: 842 scsi_exit_devinfo(); 843 cleanup_procfs: 844 scsi_exit_procfs(); 845 cleanup_queue: 846 scsi_exit_queue(); 847 printk(KERN_ERR "SCSI subsystem failed to initialize, error = %d\n", 848 -error); 849 return error; 850 } 851 852 static void __exit exit_scsi(void) 853 { 854 855 #ifdef CONFIG_DEBUG_FS > 856 debugfs_remove_recursive(scsi_debugfs_root); 857 #endif 858 scsi_netlink_exit(); 859 scsi_sysfs_unregister(); 860 scsi_exit_sysctl(); 861 scsi_exit_hosts(); 862 scsi_exit_devinfo(); 863 scsi_exit_procfs(); 864 scsi_exit_queue(); 865 async_unregister_domain(&scsi_sd_probe_domain); 866 } 867 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
