Hi Bart, 

On 4/4/19, 12:45 PM, "Bart Van Assche" <bvanass...@acm.org> wrote:

    External Email
    
    ----------------------------------------------------------------------
    Make qla2x00_get_host_fabric_name() slightly faster by changing a stack
    array into a static array. Declare that array const now that the
    wwn_to_u64() argument pointer has been declared const.
    
    Cc: Himanshu Madhani <hmadh...@marvell.com>
    Cc: Giridhar Malavali <gmalav...@marvell.com>
    Signed-off-by: Bart Van Assche <bvanass...@acm.org>
    ---
     drivers/scsi/qla2xxx/qla_attr.c | 5 +++--
     1 file changed, 3 insertions(+), 2 deletions(-)
    
    diff --git a/drivers/scsi/qla2xxx/qla_attr.c 
b/drivers/scsi/qla2xxx/qla_attr.c
    index da64fe54f59e..b8706ed3ae1d 100644
    --- a/drivers/scsi/qla2xxx/qla_attr.c
    +++ b/drivers/scsi/qla2xxx/qla_attr.c
    @@ -2723,8 +2723,9 @@ static void
     qla2x00_get_host_fabric_name(struct Scsi_Host *shost)
     {
        scsi_qla_host_t *vha = shost_priv(shost);
    -   uint8_t node_name[WWN_SIZE] = { 0xFF, 0xFF, 0xFF, 0xFF, \
    -           0xFF, 0xFF, 0xFF, 0xFF};
    +   static const uint8_t node_name[WWN_SIZE] = {
    +           0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF
    +   };
        u64 fabric_name = wwn_to_u64(node_name);
     
        if (vha->device_flags & SWITCH_FOUND)
    -- 
    2.21.0.196.g041f5ea1cf98
    
 Looks Good. 

Acked-by: Himanshu Madhani <hmadh...@marvell.com>

Reply via email to