We can use for_each_set_bit() to slightly simplify the code.

Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
- fix title by adding "fs" (Doug)
 drivers/scsi/scsi_debugfs.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/scsi_debugfs.c b/drivers/scsi/scsi_debugfs.c
index c5a8756384bc..c19ea7ab54cb 100644
--- a/drivers/scsi/scsi_debugfs.c
+++ b/drivers/scsi/scsi_debugfs.c
@@ -1,4 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
+#include <linux/bitops.h>
 #include <linux/seq_file.h>
 #include <scsi/scsi_cmnd.h>
 #include <scsi/scsi_dbg.h>
@@ -18,9 +19,7 @@ static int scsi_flags_show(struct seq_file *m, const unsigned 
long flags,
        bool sep = false;
        int i;
 
-       for (i = 0; i < sizeof(flags) * BITS_PER_BYTE; i++) {
-               if (!(flags & BIT(i)))
-                       continue;
+       for_each_set_bit(i, &flags, BITS_PER_LONG) {
                if (sep)
                        seq_puts(m, "|");
                sep = true;
-- 
2.20.1

Reply via email to