Hi Douglas,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc1 next-20190726]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Douglas-Gilbert/sg-add-v4-interface/20190727-170351
config: i386-randconfig-b002-201929 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/uapi/scsi/sg.h:35:0,
                    from <command-line>:0:
>> include/linux/bsg.h:31:10: warning: 'struct device' declared inside 
>> parameter list will not be visible outside of this definition or declaration
      struct device *parent)
             ^~~~~~
>> include/linux/bsg.h:30:50: warning: 'struct request_queue' declared inside 
>> parameter list will not be visible outside of this definition or declaration
    static inline int bsg_scsi_register_queue(struct request_queue *q,
                                                     ^~~~~~~~~~~~~
   include/linux/bsg.h:35:48: warning: 'struct request_queue' declared inside 
parameter list will not be visible outside of this definition or declaration
    static inline void bsg_unregister_queue(struct request_queue *q)
                                                   ^~~~~~~~~~~~~

vim +31 include/linux/bsg.h

3d6392cfbd7dc11 Jens Axboe        2007-07-09  24  
17cb960f29c29ee Christoph Hellwig 2018-03-13  25  int bsg_register_queue(struct 
request_queue *q, struct device *parent,
5de815a7eedfacf Christoph Hellwig 2018-05-29  26                const char 
*name, const struct bsg_ops *ops);
17cb960f29c29ee Christoph Hellwig 2018-03-13  27  int 
bsg_scsi_register_queue(struct request_queue *q, struct device *parent);
17cb960f29c29ee Christoph Hellwig 2018-03-13  28  void 
bsg_unregister_queue(struct request_queue *q);
3d6392cfbd7dc11 Jens Axboe        2007-07-09  29  #else
17cb960f29c29ee Christoph Hellwig 2018-03-13 @30  static inline int 
bsg_scsi_register_queue(struct request_queue *q,
17cb960f29c29ee Christoph Hellwig 2018-03-13 @31                struct device 
*parent)
a4ee0df8b3d007f James Bottomley   2007-07-23  32  {
a4ee0df8b3d007f James Bottomley   2007-07-23  33        return 0;
a4ee0df8b3d007f James Bottomley   2007-07-23  34  }
97f46ae45c70857 FUJITA Tomonori   2008-04-19  35  static inline void 
bsg_unregister_queue(struct request_queue *q)
a4ee0df8b3d007f James Bottomley   2007-07-23  36  {
a4ee0df8b3d007f James Bottomley   2007-07-23  37  }
17cb960f29c29ee Christoph Hellwig 2018-03-13  38  #endif /* CONFIG_BLK_DEV_BSG 
*/
17cb960f29c29ee Christoph Hellwig 2018-03-13  39  #endif /* _LINUX_BSG_H */

:::::: The code at line 31 was first introduced by commit
:::::: 17cb960f29c29ee07bf6848ada3265f4be55972e bsg: split handling of SCSI 
CDBs vs transport requeues

:::::: TO: Christoph Hellwig <h...@lst.de>
:::::: CC: Jens Axboe <ax...@kernel.dk>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to