On 2019-08-12 10:23 a.m., Christoph Hellwig wrote:
On Wed, Aug 07, 2019 at 01:42:36PM +0200, Douglas Gilbert wrote:
Re-arrange code in sg_poll(). Rename sg_read_oxfer() to
sg_rd_append(). In sg_start_req() rename rw to r0w.
Plus associated changes demanded by checkpatch.pl
r0w seems like a really odd variably name that doesn't help
readability. Also all these changes seem independent from each
other to me, so they should be split into multiple patches.
When I see a bool called "rw" I wonder whether true means write
or read. When I see a bool called "r0w" then I would guess
false means read. Maybe it's just me ...
Doug Gilbert
