On Sat, Sep 04, 1999 at 02:35:24PM +0100, Alan Cox wrote:
> The scsi code however is so hard to read its going to be quicker to clean
> it up and fix bits than to try and debug it further. Is anyone else trying
> to clean up the scsi mess currently.
>
> I'm not going to write some new scsi layer, sorry someone crazier can do that
> just to clean up the cruft, including stuff like banging it all through
> indent and extracting common code into functions, moving long complex conditional
> code into functions etc.
>
> I'd appreciate a couple of eyeballs over the following first small patches
> to extract 'do a command and wait for it'
You introduce a scsi_wait_cmd() and call it instead of putting the insns
there. Only change: spin_lock_irqsave and _irqrestore instead of _irq.
Certainly correct.
In sd, you also correct a jiffie comaparison: OK.
In short: Looks fine to me.
--
Kurt Garloff <[EMAIL PROTECTED]> Wuppertal, FRG
PGP2 key: See mail header, key servers Linux kernel development
SuSE GmbH, N�rnberg, FRG SCSI drivers: tmscsim(DC390), DC395
PGP signature
