Small suggestion on cleanup:
I noticed that most busmastering drivers duplicate the logic which determines
the direction of the data phase. (data out or in).
Each lowlevel driver parses the command descriptor block in their own unique
way to gain this information. It would be helpful if it was passed in the
Scsi_Cmnd structure by the mid-layer code. Quite a bit of duplicate code in the
lowlevel drivers could be removed by adding this. I also noticed that lots of
the low-level drivers don't fully decode all the possible SCSI opcodes
properly to determine the direction, potential future bugs can be avoided
by doing this correctly.
--
Mark Veteikis [EMAIL PROTECTED] 1-214-654-5257
Interphase Corp. 13800 Senlac Dallas Tx. 75234
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
