On Sat, Aug 05, 2000 at 06:11:35PM -0500, Kees Cook wrote:
> Type: Communications ANSI SCSI revision: 02
> ncr53c875-0-<0,0>: tagged command queue depth set to 8
> resize_dma_pool: unknown device type 9
> >From looking through the linux kernel code, I notice that in
> include/scsi/scsi.h, "TYPE_COMM" is not specified. However, in
> drivers/scsi/tmscsim.h and advansys.c, it is. No device appears to
> actually USE these defines, and in scsi.c, the 9th type in
> "scsi_device_types" IS written in as "Communications".
>
> Therefore, I'd conclude that the missing definition in include/scsi/scsi.h
> is simply just the case that no one has or uses these devices, especially
> since the "scsi_devices_types" array is populated with the information,
> I'd argue that "TYPE_COMM" *should* be included in scsi.h.
It should. As should TYPE_PRINTER.
Please add them both to include/scsi/scsi.h
(even if you don't use the TYPE_PRINTER for anything).
Regards,
--
Kurt Garloff <[EMAIL PROTECTED]> Eindhoven, NL
GPG key: See mail header, key servers Linux kernel development
SuSE GmbH, Nuernberg, FRG SCSI, Security
PGP signature
