Am Mittwoch, 20. Juli 2005 10:03 schrieb Russell King: >On Wed, Jul 20, 2005 at 09:27:05AM +0200, Rolf Eike Beer wrote: >> I found that pciserial_remove_one() only disables the device if it finds >> private data. This looks suspicious to me. Patch attached. > >Makes no difference. If we don't have the private data set, then >we have errored out during the initialisation, and we disabled the >device on the way out. Moreover, the exit function won't even be >called. > >So we actually have the guarantee that there will always be private >data here.
In this case we should just kill the test if the private data is present. If something is seriously wrong this will oops and not hide the bug. This is done in other places the same way. Eike
pgpjcMqa8wl0X.pgp
Description: PGP signature
