On Mon, Jun 12, 2000 at 10:02:38PM +1000, Andrew Morton wrote:
> Philipp Rumpf wrote:
> > 
> > ..
> > >From reading del_timer_sync, you're only allowed to use it if you use
> > timer_exit in your timer, like this:
> 
> I like your first patch.  One little modification:
> 
> > --- linux/kernel/sched.c        Sun Jun 11 17:02:22 2000
> > +++ linux-prumpf/kernel/sched.c Sun Jun 11 18:43:20 2000
> > @@ -337,15 +337,23 @@
> >         spin_unlock_irqrestore(&runqueue_lock, flags);
> >  }
> > 
> > +struct foo_struct {
> > +       struct task_struct *process;
> > +       struct timer_list *timer;
>                             ^
>                            ^^^
> 
> This can be simply 'struct timer_list timer'

Agreed.  In fact this makes the UP case be just an additional indirection
instead of wasting any stack space.

Now all we need is a a better name than foo ...


-
Linux SMP list: FIRST see FAQ at http://www.irisa.fr/prive/dmentre/smp-howto/
To Unsubscribe: send "unsubscribe linux-smp" to [EMAIL PROTECTED]

Reply via email to