On 1/10/19 4:26 PM, Vineet Gupta wrote:
> | > Also, set_mask_bits is used in fs quite a bit and we can possibly come up
> | > with a generic llsc based implementation (w/o the cmpxchg loop)
> |
> | May I also suggest changing the return value of set_mask_bits() to old.
> |
> | You can compute the new value given old, but you cannot compute the old
> | value given new, therefore old is the better return value. Also, no
> | current user seems to use the return value, so changing it is without
> | risk.
>
> Link:
> http://lkml.kernel.org/g/20150807110955.gh16...@twins.programming.kicks-ass.net
> Suggested-by: Peter Zijlstra <pet...@infradead.org>
> Cc: Miklos Szeredi <mszer...@redhat.com>
> Cc: Ingo Molnar <mi...@kernel.org>
> Cc: Jani Nikula <jani.nik...@intel.com>
> Cc: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Andrew Morton <a...@linux-foundation.org>
> Cc: Will Deacon <will.dea...@arm.com>
> Signed-off-by: Vineet Gupta <vgu...@synopsys.com>
>
Reviewed-by: Anthony Yznaga <anthony.yzn...@oracle.com>
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
