Hi Jiri,
"led_set_func_hid_lenovo" is set to "hid_lenovo_led_set"
+#if IS_ENABLED(CONFIG_HID_LENOVO)
+static int hda_fixup_thinkpad_hid_prepare(struct hda_codec *codec)
+{
+ struct hda_gen_spec *spec = codec->spec;
+ int ret = 0;
+
+ if (!is_thinkpad(codec))
+ return -ENODEV;
+ if (!led_set_func_hid_lenovo)
+ led_set_func_hid_lenovo = symbol_request(hid_lenovo_led_set);
"hid_lenovo_led_set" is introduced in "[PATCH v2 2/2] hda: thinkpad_helper: Add
support for hid-lenovo LED control". This means that "[PATCH 4/4] hda:
thinkpad_helper: Add support for hid-lenovo LED control" can only work with
applied "[PATCH 1/4] hid-lenovo: Add support for X1 Tablet cover special keys"
and "[PATCH v2 2/2] hda: thinkpad_helper: Add support for hid-lenovo LED
control".
Best regards,
Dennis
On 19.12.2016 11:09, Jiri Kosina wrote:
> On Fri, 9 Dec 2016, Dennis Wassenberg wrote:
>
>> +#if IS_ENABLED(CONFIG_THINKPAD_ACPI)
>> + if (led_set_func_tpacpi)
>> + led_set_func_tpacpi(TPACPI_LED_MUTE, !enabled);
>> +#endif
>> +#if IS_ENABLED(CONFIG_HID_LENOVO)
>> + if (led_set_func_hid_lenovo)
>> + led_set_func_hid_lenovo(HID_LENOVO_LED_MUTE, !enabled);
>
> Where does led_set_func_hid_lenovo() come from? I don't see it in Linus'
> tree as of today. Is that something else than tpacpi_led_set()?
>
> Thanks,
>
--
To unsubscribe from this list: send the line "unsubscribe linux-sound" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
