On Mon, Dec 02, 2013 at 03:19:16AM +0900, takas...@ops.dti.ne.jp wrote:

>       if (tx_buf)
>               tx_fifo(p, tx_buf, words, fifo_shift);
> +     else if (rx_buf && p->info->rx_need_dummy_tx)
> +             tx_fifo(p, rx_buf, words, fifo_shift);

This is going to transmit the contents of the RX buffer.  This means
that if there's any data in there it'll get sent but the expected
behaviour would be to send all zeros.  It's possible some devices may
misbehave if this were to happen.  It would be better to allocate some
zeros with kzalloc() and send that.

Really we should have core support for this, it's not the only
controller with such limitations.

Attachment: signature.asc
Description: Digital signature

Reply via email to