On Tue, Dec 17, 2013 at 05:00:53AM +0000, Gupta, Pekon wrote:
> >From: Huang Shijie [mailto:[email protected]]
> >On Tue, Dec 17, 2013 at 04:08:33AM +0000, Gupta, Pekon wrote:
> >>
> >> As much base code is copied from m25p90.c,
> >> Do you mind keeping the sign-offs of the original contributors of m25p80.c
> >> at-least in patches where much code is ported ?
> >I have added the lines in the spi-nor.c:
> >
> > " Cloned most of the code from the m25p80.c"
> >
> >> This would at-least give some credit to original authors and contributors.
> >I do not change any authors information of m25p80.c.
> >
> >If it is not enough? Could you remind me what to do ?
> >
> (1) Add sign-offs of main authors of m25p80, so that original contributors
> still remains in path of submission [1].
Do you mean add the sign-offs in end of the patch 3's commit message?:
Signed-off-by: Mike Lavender <[email protected]>
>
> (2) Also, please remove following from spi-nor.c
> However, you can keep this in fsl-quadspi.c.
> +MODULE_AUTHOR("Freescale Semiconductor Inc.");
> I'm sure this was _not_ present in original m25p80.c
> (m25p80.c was started as ST's driver as per MODULE_DESCRIPTION)
okay.
>
> (3) +MODULE_LICENSE("GPL");
> Also, I assume the license version should be "GPLv2" ?
yes. it should be v2.
thanks
Huang Shijie
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
