On Tue, Dec 24, 2013 at 10:26:17AM +0100, Geert Uytterhoeven wrote: > On Tue, Dec 24, 2013 at 3:59 AM, Simon Horman <[email protected]> wrote: > > On Mon, Dec 23, 2013 at 07:34:24PM +0100, Geert Uytterhoeven wrote: > >> The overrun flag should be cleared in the SPI Status Register, not in the > >> SPI Control Register, based on the SDK sample code. > >> > >> Signed-off-by: Geert Uytterhoeven <[email protected]> > > > > I don't believe that I have access to the sample code, > > but I do trust your judgement. > > It's in the public RZLSP-V1.0.1 for RZ/A1H, available from > https://oss.renesas.com/. Oh, today a new version got released.
Thanks, I was not aware of that. > > The issue is quite obvious: after clearing the bit, the new value should > be written back to the same register. > > However, the fix is not in a v3.10-rc6 version I saw, so this may matter > for LTSI. I believe that the LTSI-3.10 work from Renesas (so far mainly me) is independent of the sample code at the link above. So unless this fix ends up in v3.10 -stable, which should feed into LTSI-3.10, then it will need to be submitted to LTSI (probably be me or you) if we want it to be in LTSI. > > > Acked-by: Simon Horman <[email protected]> > > Thanks! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > [email protected] > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds > -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
