Hi Geert,
On Friday 27 December 2013 19:38:43 Geert Uytterhoeven wrote:
> On Fri, Dec 27, 2013 at 3:33 PM, Laurent Pinchart wrote:
> >> @@ -440,12 +437,13 @@ static void rspi_memory_from_8bit(void *buf, const
> >> void *data, unsigned len) static int rspi_send_dma(struct rspi_data
> >> *rspi,
> >> struct spi_transfer *t) {
> >>
> >> struct scatterlist sg;
> >>
> >> - void *buf = NULL;
> >> + const void *buf = NULL;
> >>
> >> struct dma_async_tx_descriptor *desc;
> >> unsigned len;
> >> int ret = 0;
> >>
> >> if (rspi->dma_width_16bit) {
> >>
> >> + void *tmp;
> >
> > I really dislike tmp as a variable name, as it can mean pretty much
> > anything. What about calling it tx_buf instead ?
>
> Thanks, that would indeed be a better name.
> However, Mark has already applied it to spi/for-next, so I'm not sure we
> can still change it, without sending a complete new patch.
I've noticed that after sending the reply. I think we can live with tmp for
now.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
