On Tue, Jan 07, 2014 at 03:54:25AM +0000, Chao Fu wrote:

> > Seems like there's some whitespace changes crept in here and elsewhere
> > which makes things harder to review.

> [Chao Fu] Here is some coding style not in standard in former code, 
> should I take this opportunity to modify here? 

It's fine to fix things like this but please do it as a separate patch -
it is much easier to review patches that do one thing, if there's extra
changes (especially changes that aren't mentioned in the changelog) then
people reviewing need to check harder to work out what the change is and
that it's doing what's expected.

Attachment: signature.asc
Description: Digital signature

Reply via email to