Hi Mark,
On Mon, Jan 27, 2014 at 07:22:51PM +0000, Mark Brown wrote:
> On Mon, Jan 27, 2014 at 09:18:10PM +0200, Baruch Siach wrote:
> > On Mon, Jan 27, 2014 at 07:08:39PM +0000, Mark Brown wrote:
> > > On Sun, Jan 26, 2014 at 10:14:35AM +0200, Baruch Siach wrote:
>
> > > > +Required properties:
>
> > > > +- num-cs: see spi-bus.txt
>
> > > Why is this mandatory, in the code it was optional? One or the other
> > > ought to be updated.
>
> > The code defaults to 4. I guess that's what the hardware this code was
> > tested
> > on had. But this default doesn't make much sense in the general case.
> > Anyway,
> > for backwards compatibility I'll document this property as optional, note
> > that
> > the default is 4, and recommend to add this property anyway. Does this
> > sound
> > reasonable?
>
> This is a new binding, why would it have to be backwards compatible with
> anything?
I meant driver compatibility. I used to work that way, and should continue
doing so in non-DT environment. I suggest to make num-cs mandatory for DT, but
keep the existing behaviour for non-DT. I'll update the code then.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
