On Wed, Apr 09, 2014 at 07:40:14PM +0200, Marek Vasut wrote: > On Wednesday, April 09, 2014 at 07:32:46 PM, Brian Norris wrote: > > +#define OPCODE_DUAL_READ 0x3b /* Read data bytes (Dual SPI) */ > > +#define OPCODE_QUAD_READ 0x6b /* Read data bytes (Quad SPI) */ > > This is still a little non-standard -- or rather -- inconsistent here. You > should use space after #define and \t after the name I'd say. I'd also say > these > two slipped your attention as the others do it just like that.
Thanks. I think I noticed this at one point, but in my patch juggling, I never straightened it out. I'll send v2 eventually. And in the meantime, I'm keeping my patches here: http://git.infradead.org/users/norris/linux-mtd.git/shortlog/refs/heads/spinor Brian -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
