On Fri, Nov 14, 2014 at 03:52:22PM +0000, Mark Brown wrote:
> On Fri, Nov 14, 2014 at 03:40:44PM +0000, Charles Keepax wrote:
> > We can only use page_address on memory that has been mapped using kmap,
> > when the buffer passed to the SPI has been allocated by vmalloc the page
> > has not necessarily been mapped through kmap. This means sometimes
> > page_address will return NULL causing the pointer we pass to sg_set_buf
> > to be invalid.
> 
> Hrm, this is a bug in the mxs driver (which is where we copied the core
> code from) - care to fix that too?

Yeah no problem, won't be able to test it, but should be a fairly
trivial change and hopefully someone else can test.

> 
> > As we only call page_address such that we can pass a virtual address to
> 
> s/such/so/

Will ping a respin and include the mxs fixup too.

Thanks,
Charles


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to