Right, missed that. However the code was bogus before, the status = -EINVAL didn't make sense as the value of variable status isn't used before the return. Therefore we can remove the "status = -EINVAL". Shall I submit a patch or what would be your preferred approach?
On Thu, Dec 4, 2014 at 2:15 PM, Fabio Estevam <[email protected]> wrote: > Since commit c592becbe704127 ("spi: fsl-(e)spi: migrate to generic master > queueing") the function fsl_spi_do_one_msg() is not void anymore, so return > an error code to avoid the following buid warning: > > drivers/spi/spi-fsl-spi.c: In function 'fsl_spi_do_one_msg': >>> drivers/spi/spi-fsl-spi.c:374:4: warning: 'return' with no value, in >>> function returning non-void [-Wreturn-type] > return; > ^ > > Reported-by: kbuild test robot <[email protected]> > Signed-off-by: Fabio Estevam <[email protected]> > --- > drivers/spi/spi-fsl-spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-fsl-spi.c b/drivers/spi/spi-fsl-spi.c > index e24a9bf..83f8081 100644 > --- a/drivers/spi/spi-fsl-spi.c > +++ b/drivers/spi/spi-fsl-spi.c > @@ -371,7 +371,7 @@ static int fsl_spi_do_one_msg(struct spi_master *master, > status = -EINVAL; > dev_err(&spi->dev, > "bits_per_word/speed_hz should be same for > the same SPI transfer\n"); > - return; > + return -EINVAL; > } > } > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
