Hi Mark,
> -----Original Message-----
> From: Mark Brown [mailto:[email protected]]
> Sent: Monday, August 03, 2015 9:38 PM
> To: Ranjit Abhimanyu Waghmode
> Cc: [email protected]; [email protected]; Michal Simek;
> Soren Brinkmann; [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; linux-arm-
> [email protected]; Harini Katakam; Punnaiah Choudary Kalluri; Ranjit
> Abhimanyu Waghmode; [email protected]
> Subject: Re: [LINUX RFC 1/2] mtd: spi-nor: add dual parallel mode support
>
> On Mon, Aug 03, 2015 at 02:35:06PM +0530, Ranjit Waghmode wrote:
>
> > drivers/mtd/devices/m25p80.c | 1 +
> > drivers/mtd/spi-nor/spi-nor.c | 92 ++++++++++++++++++++++++++++++++++--
> -------
> > include/linux/mtd/spi-nor.h | 3 ++
> > include/linux/spi/spi.h | 2 +
> > 4 files changed, 79 insertions(+), 19 deletions(-)
>
> You need to at least split this into two patches, one adding a new SPI
> interface
> and another using it in MTD. Probably the MTD core and driver changes need
> splitting too. Please see SubmittingPatches for discussion of splitting
> things.
>
I will split and resend the same.
> > diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h index
> > d673072..8dec349 100644
> > --- a/include/linux/spi/spi.h
> > +++ b/include/linux/spi/spi.h
> > @@ -355,6 +355,8 @@ struct spi_master {
> > #define SPI_MASTER_NO_TX BIT(2) /* can't do buffer write */
> > #define SPI_MASTER_MUST_RX BIT(3) /* requires rx */
> > #define SPI_MASTER_MUST_TX BIT(4) /* requires tx */
> > +#define SPI_MASTER_DATA_STRIPE BIT(7) /* support
> data stripe */
> > +#define SPI_MASTER_BOTH_CS BIT(8) /* enable both
> chips */
>
> This is really not adequate description for a new API, I can't tell what "data
> stripe" is supposed to mean at all and I've got at best a vague idea what
> "both
> chips" really means. This means other developers won't be able to tell how to
> use or implement these flags either, and it means I can't really review this.
> You
> need to provide more information here, both in the code and in the commit
> message.
>
I'm sorry about that. I have added description in cover letter, but will add
more information about the same here too.
> I'd also expect some handling in the core for these, for example error
> handling if
> they can't be supported.
Will update and send you the updated version.
Thanks,
Ranjit
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
