Am 25.08.2015 um 19:43 schrieb Mark Brown: > On Sun, Aug 23, 2015 at 02:20:58PM +0200, Heiner Kallweit wrote: > >> /* Register for SPI Interrupt */ >> - ret = request_irq(mpc8xxx_spi->irq, fsl_espi_irq, >> + ret = devm_request_irq(dev, mpc8xxx_spi->irq, fsl_espi_irq, >> 0, "fsl_espi", mpc8xxx_spi); > > Also, are you *sure* this conversion is safe? One trick with interrupts > is that the interrupt could still fire after the device removal function > runs since devm_ dealloacation runs after that. After each transfer interrupts are disabled (at end of fsl_espi_bufs). Therefore I *think* it's safe. And as resources are freed in reverse order (irq first), shouldn't this be enough to be on the safe side?
-- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
